[PATCH] D115934: [analyzer] Add range constructor to CallDescriptionMap

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 17 06:57:41 PST 2021


steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/unittests/StaticAnalyzer/CallDescriptionTest.cpp:24-28
+static_assert(
+    std::is_constructible<CallDescriptionMap<bool>,
+                          decltype(std::declval<ArgsContainer>().begin()),
+                          decltype(std::declval<ArgsContainer>().end())>(),
+    "should be range constructible");
----------------
I'm not even sure we need this assertion though.


================
Comment at: clang/unittests/StaticAnalyzer/CallDescriptionTest.cpp:38
 public:
   ResultMap(std::initializer_list<std::pair<CallDescription, bool>> Data)
       : Found(0),
----------------
Maybe the `ResultMap` should also follow this and declare the ctor overload.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115934/new/

https://reviews.llvm.org/D115934



More information about the cfe-commits mailing list