[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

Fri Dec 17 04:34:24 PST 2021

martong added a comment.

In D115149#3195377 <https://reviews.llvm.org/D115149#3195377>, @ASDenysPetrov wrote:

> @martong
> Thanks for clarification.
>
>> TLDR, it is recommended to use the arcanist.
>
> I'm not able to use arcanist. It doesn't work on Windows (at least I've tryed several ways to set up it).
>
> BTW. I found a revision from which the test(//symbol-simplification-nonloc-loc.cpp//) file starts to assert. It's your one D113754 <https://reviews.llvm.org/D113754>. You can checkout a revision before and test the file. I think we should investigate it deeper to understand the real cause.

Yes, as of D113754 <https://reviews.llvm.org/D113754>, we handle `IntSymExprs` in the SValBuilder, and the half of the test cases added by Balazs are such (`nonloc_OP_loc`). These are the cases that triggers the assertion.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115149/new/

https://reviews.llvm.org/D115149