[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

[Ella Ma via Phabricator via cfe-commits]

OikawaKirie added a comment.

It seems that it is not this patch that triggers the problem, which is similar to D75665 <https://reviews.llvm.org/D75665>.
IMO it is the problem of on-demand-parsing, but I do not have a Mac M1 <https://reviews.llvm.org/M1> device to reproduce this bug.
Maybe we can just land this patch by restricting the test case to be executed only on Linux, just as what D75665 <https://reviews.llvm.org/D75665> does (rG5cc18516c483 <https://reviews.llvm.org/rG5cc18516c4839fccc64b54eaa5aa447a8e1ed8fa> vs rG97e07d0c352c <https://reviews.llvm.org/rG97e07d0c352ca469eb07a0cb3162c2807ff1099d>), and leave the problem for future fixes.

Could you please do the update as provided below and land this patch again? @steakhal or other reviewers?



================
Comment at: clang/test/Analysis/ctu-lookup-name-with-space.cpp:13
+// RUN:   -verify %s
+
+void importee();
----------------
Adding this line here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102669/new/

https://reviews.llvm.org/D102669