[PATCH] D115879: [clang-format] extern with new line brace without indentation
Owen Pan via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 16 19:13:43 PST 2021
owenpan added inline comments.
================
Comment at: clang/unittests/Format/FormatTest.cpp:3819
+ Style.IndentExternBlock = FormatStyle::IEBS_NoIndent;
+ verifyFormat("extern \"C\"\n{ /*13*/\n}", Style);
+ verifyFormat("extern \"C\"\n{\n"
----------------
curdeius wrote:
> I'd prefer that you split strings after `\n`. I find it easier to read that way.
> The same below.
It's everywhere in this function. We should fix them either now or in a separate patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115879/new/
https://reviews.llvm.org/D115879
More information about the cfe-commits
mailing list