[PATCH] D115103: Leak Sanitizer port to Windows

[Vitaly Buka via Phabricator via cfe-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/lsan/lsan_allocator.h:52-53
 
-#if defined(__mips64) || defined(__aarch64__) || defined(__i386__) || \
-    defined(__arm__) || SANITIZER_RISCV64 || defined(__hexagon__)
+#if defined(__mips64) || defined(__aarch64__) || defined(_M_ARM64) || \
+    defined(__i386__) || defined(_M_IX86) || defined(__arm__) ||      \
+    defined(_M_ARM) || SANITIZER_RISCV64 || defined(__hexagon__)
----------------



================
Comment at: compiler-rt/lib/lsan/lsan_allocator.h:69
 using PrimaryAllocator = PrimaryAllocatorASVT<LocalAddressSpaceView>;
-#elif defined(__x86_64__) || defined(__powerpc64__) || defined(__s390x__)
-# if SANITIZER_FUCHSIA
+#elif defined(__x86_64__) || defined(_M_X64) || defined(__powerpc64__) || \
+    defined(__s390x__)
----------------



================
Comment at: compiler-rt/lib/lsan/lsan_common.cpp:248-253
+#  if defined(__x86_64__) || defined(_M_X64)
   // Accept only canonical form user-space addresses.
   return ((p >> 47) == 0);
 #  elif defined(__mips64)
   return ((p >> 40) == 0);
+#  elif defined(__aarch64__) || defined(_M_ARM64)
----------------
same


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115103/new/

https://reviews.llvm.org/D115103