[PATCH] D115231: [Clang] Add __builtin_reduce_xor

Thu Dec 16 02:03:09 PST 2021

RKSimon added a comment.

In D115231#3194439 <https://reviews.llvm.org/D115231#3194439>, @junaire wrote:

> In D115231#3194372 <https://reviews.llvm.org/D115231#3194372>, @RKSimon wrote:
>
>> Any reason not to handle __builtin_reduce_xor + __builtin_reduce_or as well in the same patch since they are very similar?
>
> Hi, thanks for take a look at this.
> Yes, you're right. The reason I split them is that I'm a beginner, so I want to send a "experimental patch" first, this will make review work a little bit easier if I mess something up. I think it's reasonable to add all similar builtins if currently nothing wrong about this one.

That's fine - I'm happy to see these addressed as follow up patches - cheers!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115231/new/

https://reviews.llvm.org/D115231