[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

Mingming Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 15 17:07:05 PST 2021


luna added a comment.

In D115648#3196142 <https://reviews.llvm.org/D115648#3196142>, @luna wrote:

> Simplify test case by using `-O3` to generate IR.

Probably because of the diff from `ThinLTO/X86/devirt_hybrid_after_filtering_unreachable.ll` to `ThinLTO/X86/devirt_after_filtering_unreachable.ll` is big, `git` regard a `git mv` as `git add` and `git mv` here (this stack overflow <https://stackoverflow.com/questions/42854041/renaming-with-git-using-git-mv-vs-deleting-a-file-and-adding-another/42854262>) question echoes.

So I'm going to keep it (without trying to make it look like a `mv`), wait for the pre-merge test and the local `ninja check-llvm-lto`, and then land this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115648/new/

https://reviews.llvm.org/D115648



More information about the cfe-commits mailing list