[PATCH] D115803: [clang-format] Fix tabs when using BreakBeforeTernaryOperators=false.

Marek Kurdej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 15 12:26:22 PST 2021


curdeius added a comment.

In D115803#3195115 <https://reviews.llvm.org/D115803#3195115>, @MyDeveloperDay wrote:

> So am I right in thinking the <tab> got replaced out because C.Spaces was > C.StartOfTokenColumn?  (i.e. appendIndentText was given a negative number as the 4th argument)

Yes, that's it. It's not actually negative because that's an unsigned value, so it underflows and gets big. That's also a reason why we can't just check for a non-positive value instead of a zero i. `appendIndentText` (that would be a different workaround though).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115803/new/

https://reviews.llvm.org/D115803



More information about the cfe-commits mailing list