[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

Wed Dec 15 09:14:17 PST 2021

martong added a comment.

In D115149#3192725 <https://reviews.llvm.org/D115149#3192725>, @ASDenysPetrov wrote:

> @martong wrote:
>
>> Denis, you can see in the `Revision Contents` that Diff 3 has the baseline commit `63a6348`. When I check out `63a6348` then the newly added test file triggers the assertion about `BO_Add`.
>
> Yes is see it:
> F21029827: image.png <https://reviews.llvm.org/F21029827>
> I don't get this feature. Is it a parent or something? Please explain how to interpret this table. And how can I use it myself and when?

Each time you update the patch a new row appears in this table. The `Base` is the parent of the Diff connected to the row. The `Base` is auto-filled if you use arcanist <https://secure.phabricator.com/book/phabricator/article/arcanist/>; it will not be set if you just simply upload the patch via https. Arcanist deduces the base from your local git repository by taking `HEAD~`. It might happen, however, that your parent commit is local-only (i.e. not available in the remote copy of github/llvm/llvm-project). In this case you see the hash id of the commit, but that is not a clickable URL.

If you'd like to checkout the given patch and the `Base` is available in the remote, you can simply do

  arc patch D115149

inside the top-most directory of the llvm-project of your local copy.
This will create a branch for the base commit and will apply the latest diff on top of that.

If the base is not available or you want more control then you can export the patch:

  cd llvm-project
  arc export --revision D85528 --git > /tmp/p
  patch -p1 < /tmp/p

TLDR, it is recommended to use the arcanist.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115149/new/

https://reviews.llvm.org/D115149