[PATCH] D115231: [Clang] Add __builtin_reduce_xor

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a nit. Please wait a day or two before landing in case other reviewers have concerns they haven't had the chance to raise yet.



================
Comment at: clang/include/clang/Sema/Sema.h:12773
   bool SemaBuiltinElementwiseMathOneArg(CallExpr *TheCall);
-  bool SemaBuiltinReduceMath(CallExpr *TheCall);
+  bool SemaBuiltinReduceMathPreCheck(CallExpr *TheCall);
 
----------------
If we're going to be renaming this, we should probably drop the `Sema` prefix from the name. (I'd note that we have a lot of functions prefixed with `Sema` that should be renamed, in case anyone really wants an NFC task that should be pretty trivial.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115231/new/

https://reviews.llvm.org/D115231