[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

Wed Dec 15 04:55:32 PST 2021

JonasToth added a comment.

In D54943#3194643 <https://reviews.llvm.org/D54943#3194643>, @aaron.ballman wrote:

> Thanks for pinging on this, it had fallen off my radar! @JonasToth -- did you ever get the chance to talk with @cjdb about the overlap mentioned in https://reviews.llvm.org/D54943#2950100? (The other review also seems to have stalled out, so I'm not certain where things are at.)

We talked only short in the review, but I am not sure if there is such a big overlap between the checks. The other check looks at arguments, which is something this check currently skips completely.
I think, this check should continue to avoid this analysis, too.

The underlying `ExprMutAnalyzer` is reusable (I think so, if not that should be fixed). But my current understanding is, that the argument checker already knows the values are `const`, because it matches on `const &` parameters.
IMHO keeping the checks independent would be better. Otherwise a future combined check can be aliased with specific configurations.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54943/new/

https://reviews.llvm.org/D54943