[PATCH] D115231: [Clang] Add __builtin_reduce_xor

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 15 04:40:51 PST 2021


aaron.ballman added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:2115
+
+    const auto *Arg = TheCall->getArg(0);
+    const VectorType *TyA = Arg->getType()->getAs<VectorType>();
----------------
Please spell out the type here (same below).


================
Comment at: clang/lib/Sema/SemaChecking.cpp:2116
+    const auto *Arg = TheCall->getArg(0);
+    const VectorType *TyA = Arg->getType()->getAs<VectorType>();
+    if (!TyA) {
----------------
No need to repeat the type name here (same below).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115231/new/

https://reviews.llvm.org/D115231



More information about the cfe-commits mailing list