[PATCH] D110742: [OpenCL] Add pure and const attributes to vload builtins

Sven van Haastregt via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 15 04:34:01 PST 2021


svenvh added a comment.

> Does the langref need to be amended, first, or is it okay to interpret the `readnone` attribute as it was clearly intended, without going through the process of updating the langref first?
>
> I can update this review to use `__attribute__((pure))` for all address spaces, for the time being, but it seems a shame that the poor wording in the langref might (necessarily) prevent us from making the optimal change.

Apologies for the late reply...  I'd prefer to get the langref updated first, for the sake of consistency and to ensure other stakeholders agree with the interpretation.  You can still go ahead with the `__attribute__((pure))` changes of course.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110742/new/

https://reviews.llvm.org/D110742



More information about the cfe-commits mailing list