[PATCH] D115778: [docs] Give the reason why the support for coroutine is partial

Wed Dec 15 04:28:13 PST 2021

aaron.ballman added a comment.

Thanks for this!

================
Comment at: clang/www/cxx_status.html:1202
       <td><a href="https://wg21.link/p0912r5">P0912R5</a></td>
-      <td class="partial" align="center">Partial</td>
+      <td class="partial" align="center">Partial <a href="#CoroPartialReason">(12)</a></td>
     </tr>
----------------
Rather than following this approach, it'd be nice to have the information provided directly inline, as done in: https://github.com/llvm/llvm-project/blob/main/clang/www/cxx_status.html#L916

================
Comment at: clang/www/cxx_status.html:1267-1270
+<span id="CoroPartialReason">(12): The optimizer couldn't handle TLS with
+  `__attribute__((const))` attribute correctly. It implies that there would
+  be problems if the coroutine is possible to resume on a different thread.
+</span>
----------------
Also, when moving it to be a detail of the current row, I'd drop the `(12): ` from the text.

I think we should also add some words to the effect of "This feature was implemented based on the Coroutines TS and requires further analysis to determine what support remains to be added." This should hopefully make it clear that the list of issues found is not exhaustive and that investigative work is still needed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115778/new/

https://reviews.llvm.org/D115778