[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

Tue Dec 14 20:02:43 PST 2021

luna marked an inline comment as done.
luna added a comment.

thanks for the inputs!

================
Comment at: llvm/test/ThinLTO/X86/devirt_after_filtering_unreachable.ll:16
+
+; ENABLESPLITFLAG: gv: (name: "_ZN4BaseD0Ev", {{.*}}, funcFlags: ({{.*}} mustBeUnreachable: 1
+
----------------
tejohnson wrote:
> I think it can be shared with the equivalent checks in the unsplit case as well. And probably with a check-prefix name that reflects what is being checked (e.g. UNREACHABLEFLAG), or maybe something simpler (e.g. FLAG).
Use UNREACHABLEFLAG and share it across split and unsplit case.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115648/new/

https://reviews.llvm.org/D115648