[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

[Michael Spencer via cfe-commits]

On Tue, Dec 14, 2021 at 6:17 PM Richard Smith - zygoloid via Phabricator <
reviews at reviews.llvm.org> wrote:

> rsmith added inline comments.
>
>
> ================
> Comment at: clang/test/ClangScanDeps/modulemap-via-vfs.m:5-6
> +// RUN: sed -e "s|DIR|%/t.dir|g" %t.dir/build/vfs.yaml.in >
> %t.dir/build/vfs.yaml
> +// RUN: clang-scan-deps -compilation-database
> %t.dir/build/compile-commands.json -j 1 -format experimental-full \
> +// RUN:   -mode preprocess-minimized-sources -generate-modules-path-args
> > %t.db
> +// RUN: %python %S/../../utils/module-deps-to-rsp.py %t.db
> --module-name=A > %t.A.cc1.rsp
> ----------------
> There seems to be a problem with this test: it's writing a module cache to
> the current working directory instead of writing it into somewhere under
> `%t`. Presumably this just requires adding a module cache path parameter?
>

Hmm, likely correct. I'll add that to the compilation database. I'm not
sure if the other tests are missing that too.

- Michael Spencer



>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D114206/new/
>
> https://reviews.llvm.org/D114206
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211214/72d77940/attachment-0001.html>