[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

[Sjoerd Meijer via Phabricator via cfe-commits]

SjoerdMeijer added a comment.

Ok, fair enough, perhaps adding features is a valid use-case.

I will refrain from commenting on "things are terribly broken".  I agree it is broken, but in a different way than suggested in previous comments. 
If others also think this makes sense, then here a few follow up remarks from my side:

- First of all, this (really) sets precedent for setting options in a different way. This needs documentation and release noting.
- If we are going to do this, this should be the first patch in a series to fix this for all features. We can't just do a few of them.
- There was a suggestion to allow adding features with -march=+feature. Was this dismissed in favour of how things works for x86 and be consistent with that?
- It would be really good if we keep options consistent/compatible across the GCC and Clang toolchains. Any possibility to check with GCC community if they are open for this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113779/new/

https://reviews.llvm.org/D113779