[PATCH] D115715: [clang-tidy] Fix llvm-header-guard for Windows paths containing drive letter (e.g. C:).

Stephan Bergmann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 14 01:59:30 PST 2021


sberg added a comment.

> So the check, for a file called e.g. "C:\test\test.h" would suggest the guard C:_TEST_TEST_H being an invalid name due to the presence of the colon.

...though the new suggestion `C__TEST_TEST_H` isn't ideal either, in that it uses an identifier that is reserved for the implementation (due to the double underscore)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115715/new/

https://reviews.llvm.org/D115715



More information about the cfe-commits mailing list