[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

Tue Dec 14 01:54:07 PST 2021

martong added a comment.

In D115149#3188743 <https://reviews.llvm.org/D115149#3188743>, @ASDenysPetrov wrote:

>> @steakhal
>> I don't get this one. I've provided a bunch of tests, even annotated with `no-crash` comments where we crashed prior to this change.
>
> I wasn't able to catch any crashes with your tests file //(symbol-simplification-nonloc-loc.cpp)// on the baseline before your patch (D115149#3180005 <https://reviews.llvm.org/D115149#3180005>). So I ask you to provide the concrete example you've caught which promted you to do this patch.

Denis, you can see in the `Revision Contents` that Diff 3 has the baseline commit `63a6348`. When I check out `63a6348` then the newly added test file triggers the assertion about `BO_Add`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115149/new/

https://reviews.llvm.org/D115149