[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

[Esme Yi via Phabricator via cfe-commits]

Esme added a comment.

In D115503#3188302 <https://reviews.llvm.org/D115503#3188302>, @dblaikie wrote:

> Got any data on how much this (combined with the LLVM patch) increases debug info size of, say, a clang self-host build? I assume not much, but wouldn't hurt to know.

Before:

  $ size clang
     text	   data	    bss	    dec	  
  302446131	10748172	 511744	313706047 --> total size is 627412094

After:

  $ size clang
     text	   data	    bss	    dec	    
  302446483	10748172	 511744	313706399 --> total size is 627412798

I built two self-host Clangs with and without the two patches, got results showing there is 704 bytes of debug info increased. I think this is acceptable?

> (does GCC produce this sort of debug info, or does it skip the access specifiers on nested types?)

Yes, GCC also emits the access attribute for nested types when the access level doesn't equal to the default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115503/new/

https://reviews.llvm.org/D115503