[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added a comment.

In D115661#3190324 <https://reviews.llvm.org/D115661#3190324>, @JonChesterfield wrote:

> Patch looks ok to me. This will fix the miscompile (we end up with a store to addrspace(4) at present) without upsetting whatever hacks rely on addrspace(4). @arsenm reasonable as a point fix?

Yes, I'm mostly saying to not waste your time trying to infer addrspace(4) in InferAddressSpaces or anything like that


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115661/new/

https://reviews.llvm.org/D115661