[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

Collin Baker via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 13 11:48:07 PST 2021


collinbaker marked 2 inline comments as done.
collinbaker added inline comments.


================
Comment at: clang/lib/Driver/ToolChain.cpp:500
+  if (getTriple().isAndroid() &&
+      getTriple().getEnvironmentName() != "android") {
+    llvm::outs() << getTriple().getEnvironmentName() << "\n";
----------------
thakis wrote:
> Why do you need the environment check?
This skips adding an extra path if the triple doesn't have an Android API level.

E.g. for the target triple aarch64-unknown-linux-android23, the environment name will be "android23". The condition will be true since "android23" != "android", and the extra path will be appended. If it had just been "android" it'll skip this step.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115049/new/

https://reviews.llvm.org/D115049



More information about the cfe-commits mailing list