[PATCH] D115622: [Debugify] Optimize debugify original mode

Djordje Todorovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 13 03:38:44 PST 2021


djtodoro created this revision.
djtodoro added reviewers: Orlando, StephenTozer.
djtodoro added projects: debug-info, LLVM.
Herald added subscribers: ormris, hiraditya.
djtodoro requested review of this revision.
Herald added a project: clang.
Herald added subscribers: llvm-commits, cfe-commits.

Before we start addressing the issue with having a lot of false positives when using debugify in the original mode, we have made a few patches that should speed up the execution of the testing utility Passes.

For example, when testing a large project (let's say LLVM project itself), we can face a lot of potential DI issues. Usually, we use `-verify-each-debuginfo-preserve` (that is very similar to `-debugify-each`) -- it collects DI metadata before each Pass, and after the Pass it checks if the Pass preserved the DI metadata. However, we can speed up this process, since we don't need to collect DI metadata before each pass -- we could use the DI metadata that are collected after the previous Pass from the pipeline as an input for the next Pass.

This patch speeds up the utility for ~2x.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D115622

Files:
  clang/lib/CodeGen/BackendUtil.cpp
  llvm/include/llvm/Transforms/Utils/Debugify.h
  llvm/lib/Transforms/Utils/Debugify.cpp
  llvm/tools/opt/opt.cpp
  llvm/unittests/Transforms/Utils/DebugifyTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115622.393832.patch
Type: text/x-patch
Size: 26777 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211213/247c15d6/attachment-0001.bin>


More information about the cfe-commits mailing list