[PATCH] D115521: [Templight] Don't display empty strings for names of unnamed template parameters

Ábel Sinkovics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 11 07:37:16 PST 2021


sabel83 added inline comments.


================
Comment at: clang/lib/Frontend/FrontendActions.cpp:554
+
+    llvm_unreachable("Failed to retrieve a name for this entry!");
+  }
----------------
Have you considered generating some default text here?

In case a new, uncovered case does not get covered here in the future generating something like `unknown type` can keep the overall output (apart from this type) usable until the bug gets fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115521/new/

https://reviews.llvm.org/D115521



More information about the cfe-commits mailing list