[PATCH] D115355: Fix build failure with GCC 11 in C++20 mode

Evgeny Mandrikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 11 00:13:03 PST 2021


Godin added a comment.

Can someone please commit this on my behalf since I do not have commit rights?



================
Comment at: clang/lib/AST/ASTImporter.cpp:8400-8403
+  AttrArgImporter(const AttrArgImporter<T> &) = delete;
+  AttrArgImporter(AttrArgImporter<T> &&) = default;
   AttrArgImporter<T> &operator=(const AttrArgImporter<T> &) = delete;
   AttrArgImporter<T> &operator=(AttrArgImporter<T> &&) = default;
----------------
dexonsmith wrote:
> Might be nice to remove the implied `<T>`s in the parameters/returns (here and elsewhere) as a follow up; a bit noisy to read those, even if it doesn't cause a build failure (probably separately from this patch).
Thank you for the review @dexonsmith !

I will also prefer such cleanup to be done separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115355/new/

https://reviews.llvm.org/D115355



More information about the cfe-commits mailing list