[PATCH] D112915: [clang][modules] Track included files per submodule

[Jan Svoboda via Phabricator via cfe-commits]

jansvoboda11 added a comment.

In D112915#3141417 <https://reviews.llvm.org/D112915#3141417>, @vsapsai wrote:

> I think AST format for `IncludedFiles` was discussed here, so I'll continue here though the bulk of implementation is in D114095 <https://reviews.llvm.org/D114095> now. Have you compared the size of resulting .pcm files when you are using a bitvector compared to a list of included headers? In my quick check (which is not a perfect comparison, to be honest) bitvector approach takes more space. For example, Darwin.pcm is 7320 bytes bigger, UIKit.pcm is 2388 bytes bigger, and entire modules cache is 14KB bigger. I haven't checked the details of the discrepancies, so curious if you have some insights already. For the record, I was testing with
>
>   echo '#import <UIKit/UIKit.h>' | path/to/built/bin/clang -fsyntax-only -isysroot "$(xcrun --sdk iphoneos --show-sdk-path)" -target arm64-apple-ios -fmodules -fmodules-cache-path=modules.noindex -x objective-c -

Replied in D114095 <https://reviews.llvm.org/D114095>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112915/new/

https://reviews.llvm.org/D112915