[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

[Jeroen Dobbelaere via Phabricator via cfe-commits]

jeroen.dobbelaere added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenFunction.h:2511
+    return LValue::MakeAddr(Addr, T, getContext(), LValueBaseInfo(Source),
+                            CGM.returnNullTBAA());
+  }
----------------
Looking at how a 'null tbaa'is produced in other places (grep for 'TBAAAccessInfo()', I would just do a 'TBAAAccessInfo()' here and omit the new ''returnNullTBAA' method.




================
Comment at: clang/test/CodeGen/avoidTBAAonASMstore.cpp:6
+	__asm { fnstcw word ptr[ControlWord] };
+// CHECK: store i64 %2, i64* %1, align 4
+// CHECK-NOT: !tbaa
----------------
Will this also work in release mode ? Maybe abstract away the %2 and %1.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115320/new/

https://reviews.llvm.org/D115320