[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

Paul Altin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 8 14:03:53 PST 2021


paulaltin added a comment.

> Thanks! Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution?

That would be great, thanks! You can use "Paul Altin <paul at liquidinstruments.com>" for the attribution.

> We're definitely happy to consider these kinds of changes, thank you! We usually prefer finding ways to silence the diagnostic in code (like casting to void to silence an unused variable warning, etc) over configuration options, but that's not always plausible to do and so extra configuration options are a good fallback solution.

Ok, fantastic. I'll go back through the checks that we've disabled and see what I can suggest.

Thanks @aaron.ballman!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112881/new/

https://reviews.llvm.org/D112881



More information about the cfe-commits mailing list