[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Dec 8 06:45:53 PST 2021
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, LGTM! sorry for taking so long.
================
Comment at: clang-tools-extra/clangd/Headers.cpp:142
private:
+ // Level will be increased every time we enter the file and reduced every
+ // time we leave it. The main file is on top of the stack because it is
----------------
maybe just `Keeps track of include depth for the current file. It's 1 for main file.` ?
================
Comment at: clang-tools-extra/clangd/Headers.cpp:210
+ CI.getPreprocessor().addCommentHandler(Collector.get());
+ CI.getPreprocessor().addPPCallbacks(move(Collector));
}
----------------
s/move/std::move/g
================
Comment at: clang-tools-extra/clangd/Headers.h:128
// Returns a PPCallback that visits all inclusions in the main file and
+ // populates the structure. IncludeCollector can also scan the comments for
----------------
I suppose the comment needs updating too. (it no longer `returns` nor requires extra comment handler insertion).
`Inserts a PPCallback and CommentHandler that'll populate this structure.` ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114072/new/
https://reviews.llvm.org/D114072
More information about the cfe-commits
mailing list