[PATCH] D115254: Use VersionTuple for parsing versions in Triple

James Farrell via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 8 06:42:45 PST 2021


jamesfarrell added a comment.

In D115254#3177960 <https://reviews.llvm.org/D115254#3177960>, @MaskRay wrote:

> commit 219672b8dd06c4765185fa3161c98437d49b4a1b <https://reviews.llvm.org/rG219672b8dd06c4765185fa3161c98437d49b4a1b> says `Revert "Revert "...""`
>
> For such commits, it is customary to use "Reland " and the commit message should include the original message (people don't like chasing through several commits to obtain the important original message) and a short note about what was fixed, so that people doing archaeology can know better what's going on.

Ugh...I described it very carefully in the summary for https://reviews.llvm.org/D115254, but didn't realize that was not what got attached to the change when I merged it. Apologies.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115254/new/

https://reviews.llvm.org/D115254



More information about the cfe-commits mailing list