[PATCH] D112616: Fix crash on invalid code involving late parsed inline methods

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 7 11:25:41 PST 2021


rjmccall added a comment.

The only alternative to this that I can see would be for the invalid code to produce more valid-seeming AST.

Are deduction guides just not normally allowed for methods?

Also, while I don't think it would eliminate the need to be defensive here, our recovery from misnamed constructors is pretty bad, and it would be great if we recognized that pattern in the parser.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112616/new/

https://reviews.llvm.org/D112616



More information about the cfe-commits mailing list