[PATCH] D114665: [clangd] Make a.k.a printing configurable.

liu hui via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 7 09:00:19 PST 2021


lh123 marked an inline comment as done.
lh123 added inline comments.


================
Comment at: clang-tools-extra/clangd/ConfigFragment.h:271
+  /// Describes hover preferences.
+  struct HoverBlock {
+    /// Whether hover show a.k.a type.
----------------
sammccall wrote:
> One question is whether the setting should control hover specifically, or whether it covers "in places we print types" more generally. But it doesn't seem likely we'll make this configurable for diagnostics, and I don't have other examples. Most of our settings are per-feature. So I think this is right as it is.
In the future, the AKA type can also be displayed in the signature help, but I don't know the best place for this option.(for now, it should be fine to put this setting in hover)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114665/new/

https://reviews.llvm.org/D114665



More information about the cfe-commits mailing list