[PATCH] D115235: [clang][dataflow] Implement a basic algorithm for dataflow analysis

[Dmitri Gribenko via Phabricator via cfe-commits]

gribozavr2 added a comment.

LGTM but deferring approval to @xazax.hun .



================
Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:30
+public:
+  void run(const ast_matchers::MatchFinder::MatchResult &Result) override {
+    const auto *Func = Result.Nodes.getNodeAs<FunctionDecl>("func");
----------------
Add `assert(BlockStates.empty());` ?


================
Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:58
+std::vector<llvm::Optional<DataflowAnalysisState<typename AnalysisT::Lattice>>>
+runAnalysis(const char *Code) {
+  std::unique_ptr<ASTUnit> AST =
----------------
Please prefer StringRef to `const char *` if possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115235/new/

https://reviews.llvm.org/D115235