[PATCH] D114885: Use VersionTuple for parsing versions in Triple, fixing issues that caused the original change to be reverted. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 7 05:22:11 PST 2021


thakis added a comment.

In D114885#3174152 <https://reviews.llvm.org/D114885#3174152>, @jamesfarrell wrote:

> In D114885#3174074 <https://reviews.llvm.org/D114885#3174074>, @thakis wrote:
>
>> Oh, it's already reverted, apologies. We'll know if that fixed that bot in 15 min or so then. Something to keep in mind for relanding though :)
>
> Yeah, I'm currently trying to build and test on my Mac laptop. It's not ARM tho, so if the test passes there I'm not sure what my next steps are to land this change.

It seems to also fail on other arm bots. Chances are it'll fail locally on intel machines if you run cmake with `-DLLVM_DEFAULT_TARGET_TRIPLE=arm64-apple-darwin` (or some other arm triple). Does that help? (I haven't tried it in this case, but most of the time that's sufficient to repro arm-host issues on non-host machines.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114885/new/

https://reviews.llvm.org/D114885



More information about the cfe-commits mailing list