[PATCH] D114522: [clangd] Add desugared type to hover

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 7 03:57:48 PST 2021


sammccall added a comment.

In D114522#3156167 <https://reviews.llvm.org/D114522#3156167>, @kadircet wrote:

> Have a list of user-configurable FQNs that AKA printing would be disabled for (and provide a good set of defaults inside clangd for STL)

BTW this seems hard to implement well without invasive changes to the desugar logic.

Nontrivial case: the list is `{std::string}`, the type is `std::string*`.

Pathological case: the list is `{std::string}`, and the type is `pair<std::string*, size_t>`. Desugar yields `pair<basic_string<char>*, long long>`, desired output is `pair<std::string*, long long>`.
desugarForDiagnostic needs to exclude the first TP from desugaring based on it matching a string, but we don't stringify all the intermediate types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114522/new/

https://reviews.llvm.org/D114522



More information about the cfe-commits mailing list