[PATCH] D115103: Leak Sanitizer port to Windows
MyDeveloperDay via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Dec 7 00:10:04 PST 2021
MyDeveloperDay added a subscriber: kuhnel.
MyDeveloperDay added inline comments.
================
Comment at: compiler-rt/lib/lsan/lsan_common.h:48
+#elif SANITIZER_NETBSD || SANITIZER_FUCHSIA || SANITIZER_WINDOWS
+# define CAN_SANITIZE_LEAKS 1
#else
----------------
vitalybuka wrote:
> MyDeveloperDay wrote:
> > you probably don't want to change this do you?
> I am fine like this, fighting clang-format is not useful
> however it would be nice if you clang-format relevant block in a separate patch then then rebase this patch on top of it
it might not seem useful to individuals, but I think its the guidance, and a consistent style really help new people to understand what's going on.
https://llvm.org/docs/Contributing.html#how-to-submit-a-patch
I'm a little surprise the "llvm-premerge-checks" didn't highlight this @kuhnel
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115103/new/
https://reviews.llvm.org/D115103
More information about the cfe-commits
mailing list