[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

[Marek Kurdej via Phabricator via cfe-commits]

curdeius added inline comments.


================
Comment at: clang/lib/Format/Format.cpp:2598
+    // Skip past until we think we we the rawstring literal close.
+    if (Trimmed.contains("R\"(")) {
+      FormattingOff = true;
----------------
HazardyKnusperkeks wrote:
> curdeius wrote:
> > This won't be enough for raw literals with custom delimiter e.g. `R"xyz(...)xyz"`.
> > But well, without any code parsing, this function will always be easily outsmarted I guess.
> > Maybe we can use regexp here and save the delimiter? (And then check it below)
> And then we need to check first for closing, since we can close and reopen on the same line, or not?
It's done below anyway (i.e. `Trimmed` is still the same line), nope?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115168/new/

https://reviews.llvm.org/D115168