[PATCH] D115039: [HIP] Fix -fgpu-rdc for Windows

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 6 10:40:12 PST 2021


tra added a comment.

> Put __hip_gpubin_handle in comdat when it has linkonce_odr linkage.

I wonder when would this happen? I'm not sure we ever want gpubin handles from different TUs merged.  I think it may result in different TUs attempting to load/init the same GPU binary multiple times.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115039/new/

https://reviews.llvm.org/D115039



More information about the cfe-commits mailing list