[PATCH] D115121: Add support for return values in bugprone-stringview-nullptr
    CJ Johnson via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Sun Dec  5 13:49:57 PST 2021
    
    
  
CJ-Johnson added inline comments.
================
Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-stringview-nullptr.cpp:94-95
+
+// TODO: Handle cases where types, such as Class and Struct below, are
+//       constructed with null arguments.
+class Class {
----------------
I attempted to address this TODO but it is quite the rabbit hole. If I just add a basic fallback matcher, `applyFirst(...)` does not have the behavior I desire. It was stomping on other, better fixes.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115121/new/
https://reviews.llvm.org/D115121
    
    
More information about the cfe-commits
mailing list