[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

Marek Kurdej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 4 12:21:18 PST 2021


curdeius added inline comments.


================
Comment at: clang/lib/Format/TokenAnnotator.cpp:3054
+      return true;
+    // & // comment
+    if (Right.is(TT_BlockComment))
----------------
Block, not line, comment


================
Comment at: clang/unittests/Format/FormatTest.cpp:1947
   verifyFormat("int&& c = f3();", Style);
+  verifyFormat("for (auto a = 0, b = 0; const auto& c : {1, 2, 3})", Style);
 
----------------
How about pointers/references in the init? Also, please test sth else than auto, both in init and as the loop variable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115050/new/

https://reviews.llvm.org/D115050



More information about the cfe-commits mailing list