[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 3 19:02:55 PST 2021


owenpan accepted this revision.
owenpan added a comment.
This revision is now accepted and ready to land.

In D115061#3170908 <https://reviews.llvm.org/D115061#3170908>, @HazardyKnusperkeks wrote:

> No I don't think there is a performance penalty. **I** just don't like using pointers. I'm happy to drop this, if the Style says to use pointers. But from what I've seen in clang-format pointers are mostly used when it can be null, but there is a wild mix.

I don't think LLVM Coding Standards specify it one way or the other, so it LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115061/new/

https://reviews.llvm.org/D115061



More information about the cfe-commits mailing list