[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

Marek Kurdej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 3 13:03:24 PST 2021


curdeius added a comment.

What do we usually do for output parameters?
I'm ok with both refs and pointers. It seems to me to be google-style thingy to pass by pointer.
It is indeed clearer at the caller site that the passed variable will be modified.
Are you worried about any performance penalty when using pointers? If so, adding `nonnull` attribute or sth like this may help.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115061/new/

https://reviews.llvm.org/D115061



More information about the cfe-commits mailing list