[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

Bal√°zs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 3 04:32:42 PST 2021


steakhal added a comment.

L129 and L135 are uncovered by tests. The rest of the lines are covered by tests, according to `lcov`.

The checker produced in total 15 reports on these 18 projects:
`memcached,tmux,curl,twin,vim,openssl,sqlite,ffmpeg,postgres,tinyxml2,libwebm,xerces,bitcoin,protobuf,qtbase,codechecker,contour,llvm-project`
You can check the reports by following this link:
https://codechecker-demo.eastus.cloudapp.azure.com/Default/reports?is-unique=on&detection-status=New&detection-status=Reopened&detection-status=Unresolved&run=%2aD91000-diff-4&checker-name=cert-msc24-c&diff-type=New

It seems like none of these projects actually use the //annex K// functions, which is not really a surprise.
VLC <https://github.com/videolan/vlc> and lighttpd <https://github.com/lighttpd/lighttpd1.4> seems to use it. @futogergely could you please run your check on those projects?



================
Comment at: clang-tools-extra/docs/clang-tidy/checks/cert-msc24-c.rst:13
+For the following functions, replacement is suggested from annex K: `asctime`, 
+`ctime`, `fopen`, `freopen`, `bsearch`, `fprintf`, `fscanf`, `fwprintf`, `fwscanf`, 
+`getenv`, `gmtime`, `localtime`, `mbsrtowcs`, `mbstowcs`, `memcpy`, `memmove`, `printf`, 
----------------
remove trailing whitespaces


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91000/new/

https://reviews.llvm.org/D91000



More information about the cfe-commits mailing list