[PATCH] D114949: [clangd] IncludeCleaner: Do not require forward declarations of RecordDecls when definition is available
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Dec 3 00:06:52 PST 2021
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks!
================
Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:127
+ // declared multiple times. The most common two cases are:
+ // - Definition available in TU, only mark that one as usage. rest is
+ // likely to be unnecessary. this might result in false positives when an
----------------
i know it was me who didn't capitalize, but can you capitalize the first words :D
s/rest/Rest
s/this/This (line below)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114949/new/
https://reviews.llvm.org/D114949
More information about the cfe-commits
mailing list