[PATCH] D114968: [clang][deps] Avoid reading file for stat calls

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 2 23:58:24 PST 2021

arphaman added a comment.

In D114968#3168123 <https://reviews.llvm.org/D114968#3168123>, @dexonsmith wrote:

> In D114968#3167519 <https://reviews.llvm.org/D114968#3167519>, @jansvoboda11 wrote:
>> Assuming the filesystem doesn't change during dependency scanning, this change keeps the consistency between stat/read calls for minimized files.
>> Thinking about it some more though, the original reason for reading files eagerly (even for stat calls) was most likely to avoid inconsistencies when the file changes on the filesystem between stat and read. Is that correct, @arphaman? If so, I think I should abandon this patch.
> Agreed; that consistency is important. I don't think stat should be decoupled from reading the file.

Yes, exactly, it was to avoid the file system change inconsistencies. it should not be decoupled .

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list