[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 2 15:02:05 PST 2021


aaron.ballman added a comment.

In D108643#3158232 <https://reviews.llvm.org/D108643#3158232>, @aaron.ballman wrote:

> In D108643#3140927 <https://reviews.llvm.org/D108643#3140927>, @aaron.ballman wrote:
>
>> In D108643#3093323 <https://reviews.llvm.org/D108643#3093323>, @aaron.ballman wrote:
>>
>>> In D108643#3106438 <https://reviews.llvm.org/D108643#3106438>, @aaron.ballman wrote:
>>>
>>>> Ping
>>>
>>> Ping.
>>
>> Ping.
>
> Ping.

Final ping.

This review hasn't received any attention for almost two months (Oct 13 was the last feedback received). In an off-list discussion, @rjmccall said that he did not think this review needs to be blocked on the ABI bits. To that end, if I don't hear back either approval or some direction on the current patch by Tue (Dec 7), I intend to move forward with a modified version of this patch. My plan is to proceed with a final review of the renaming of `_ExtInt` to `_BitInt` along with the Itanium ABI mangling changes, but I am going to drop the generic ABI document and start a separate review for that as that is not a blocking concern for the rename work.

If you have opinions on this plan, now would be a good time to speak up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108643/new/

https://reviews.llvm.org/D108643



More information about the cfe-commits mailing list