[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

Thu Dec 2 12:29:41 PST 2021

aaron.ballman added a comment.

In D108560#3167847 <https://reviews.llvm.org/D108560#3167847>, @salman-javed-nz wrote:

> Thanks for the investigation. Just exploring the options...
>
> With regards to reverting it, is the cat out of the bag? I already see some usage of the NOLINTBEGIN feature in other projects.
> There's also a NOLINT check globbing feature that builds on top of this, so it's not as simple as just backing out one commit.
>
> I can have a go at coming up with a solution where it does some caching of the NOLINT marker positions when a diagnostic is generated in a file. That would probably help a lot with the performance. It wouldn't be too complicated to implement either. Would you be happy with something like that?
>
> If the current code stayed in the main repo, how long could you afford to wait for me to provide a patch?

I would say that for me personally, at a maximum, we have to either fix or revert before this goes out in a release of Clang (because Clang 13 did not have support for NOLINTBEGIN/NOLINTEND, so this is technically unreleased functionality).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108560/new/

https://reviews.llvm.org/D108560