[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

Salman Javed via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 2 12:22:00 PST 2021

salman-javed-nz added a comment.

Thanks for the investigation. Just exploring the options...

With regards to reverting it, is the cat out of the bag? I already see some usage of the NOLINTBEGIN feature in other projects.
There's also a NOLINT check globbing feature that builds on top of this, so it's not as simple as just backing out one commit.

I can have a go at coming up with a solution where it does some caching of the NOLINT marker positions when a diagnostic is generated in a file. That would probably help a lot with the performance. It wouldn't be too complicated to implement either. Would you be happy with something like that?

If the current code stayed in the main repo, how long could you afford to wait for me to provide a patch?

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list