[PATCH] D114981: [clang-tidy] Disable support for NOLINTBEGIN/NOLINTEND blocks by default.

Yitzhak Mandelbaum via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 2 11:59:47 PST 2021


ymandel created this revision.
Herald added subscribers: carlosgalvezp, xazax.hun.
ymandel requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.

This patch parameterizes the clang-tidy diagnostic consumer with a boolean that
controls whether to honor NOLINTBEGIN/NOLINTEND blocks. The current support for
scanning these blocks is very costly -- O(n*m) in the size of files (n) and
number of diagnostics found (m), with a large constant factor.  So, the patch
disables the feature by default.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D114981

Files:
  clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
  clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114981.391418.patch
Type: text/x-patch
Size: 6343 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211202/1722b9b8/attachment-0001.bin>


More information about the cfe-commits mailing list