[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 2 11:53:41 PST 2021


arsenm added a comment.

In D114957#3167700 <https://reviews.llvm.org/D114957#3167700>, @arsenm wrote:

> I think this macro is purely terrible and should not be added (and at least should be all caps?). If we can't just hard break users, I would rather just leave the builtin signatures broken

Rather than adding an ad-hoc named macro, could they just directly check the clang version?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114957/new/

https://reviews.llvm.org/D114957



More information about the cfe-commits mailing list